DataViews: update renderFormElements to make sure the value respects the type
#64391
+5
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Code Quality
youknowriad
reviewed
Aug 9, 2024
| @@ -53,7 +53,7 @@ function Edit< Item >( { | |||
| ( newValue: string | undefined ) => | |||
| onChange( ( prevItem: Item ) => ( { | |||
| ...prevItem, | |||
| [ id ]: newValue, | |||
| [ id ]: Number( newValue ), | |||
There was a problem hiding this comment.
Yes, I actually did that as well in #64389
getdave
pushed a commit
that referenced
this pull request
Aug 14, 2024
…s the type (#64391) Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #64338
What?
Make sure the updated value for integer fields remains a number and not a string.
Why?
We want the value to respect the field type.
Testing Instructions
Go to DataForm's storybook and change the author value to something else. Using panel or regular layout. It should always display the name, never the number.